任务2.5

2025-10-31 16:49:35 +08:00
parent 4e87436cc0
commit bc6a960451
7 changed files with 301 additions and 133 deletions
--- a/internal/app/api/api.go
+++ b/internal/app/api/api.go
@@ -27,7 +27,6 @@ import (
 	"git.huangwc.com/pig/pig-farm-controller/internal/app/service"
 	"git.huangwc.com/pig/pig-farm-controller/internal/app/webhook"
 	"git.huangwc.com/pig/pig-farm-controller/internal/domain/audit"
-	domain_notify "git.huangwc.com/pig/pig-farm-controller/internal/domain/notify"
 	"git.huangwc.com/pig/pig-farm-controller/internal/domain/scheduler"
 	"git.huangwc.com/pig/pig-farm-controller/internal/domain/token"
 	"git.huangwc.com/pig/pig-farm-controller/internal/infra/config"
@@ -67,9 +66,9 @@ func NewAPI(cfg config.ServerConfig,
 	monitorService service.MonitorService,
 	deviceService service.DeviceService,
 	planService service.PlanService,
+	userService service.UserService,
 	tokenService token.Service,
 	auditService audit.Service,
-	notifyService domain_notify.Service,
 	listenHandler webhook.ListenHandler,
 ) *API {
 	// 使用 echo.New() 创建一个 Echo 引擎实例
@@ -92,7 +91,7 @@ func NewAPI(cfg config.ServerConfig,
 		config:        cfg,
 		listenHandler: listenHandler,
 		// 在 NewAPI 中初始化用户控制器，并将其作为 API 结构体的成员
-		userController: user.NewController(userRepo, monitorService, logger, tokenService, notifyService),
+		userController: user.NewController(userService, logger),
 		// 在 NewAPI 中初始化设备控制器，并将其作为 API 结构体的成员
 		deviceController: device.NewController(deviceService, logger),
 		// 在 NewAPI 中初始化计划控制器，并将其作为 API 结构体的成员
--- a/internal/app/controller/user/user_controller.go
+++ b/internal/app/controller/user/user_controller.go
@@ -6,38 +6,24 @@ import (
 	"git.huangwc.com/pig/pig-farm-controller/internal/app/controller"
 	"git.huangwc.com/pig/pig-farm-controller/internal/app/dto"
 	"git.huangwc.com/pig/pig-farm-controller/internal/app/service"
-	domain_notify "git.huangwc.com/pig/pig-farm-controller/internal/domain/notify"
-	"git.huangwc.com/pig/pig-farm-controller/internal/domain/token"
 	"git.huangwc.com/pig/pig-farm-controller/internal/infra/logs"
-	"git.huangwc.com/pig/pig-farm-controller/internal/infra/models"
-	"git.huangwc.com/pig/pig-farm-controller/internal/infra/repository"
 	"github.com/labstack/echo/v4"
-	"gorm.io/gorm"
 )

 // Controller 用户控制器
 type Controller struct {
-	userRepo       repository.UserRepository
-	monitorService service.MonitorService
-	tokenService   token.Service
-	notifyService  domain_notify.Service
-	logger         *logs.Logger
+	userService service.UserService
+	logger      *logs.Logger
 }

 // NewController 创建用户控制器实例
 func NewController(
-	userRepo repository.UserRepository,
-	monitorService service.MonitorService,
+	userService service.UserService,
 	logger *logs.Logger,
-	tokenService token.Service,
-	notifyService domain_notify.Service,
 ) *Controller {
 	return &Controller{
-		userRepo:       userRepo,
-		monitorService: monitorService,
-		tokenService:   tokenService,
-		notifyService:  notifyService,
-		logger:         logger,
+		userService: userService,
+		logger:      logger,
 	}
 }

@@ -59,28 +45,13 @@ func (c *Controller) CreateUser(ctx echo.Context) error {
 		return controller.SendErrorResponse(ctx, controller.CodeBadRequest, err.Error())
 	}

-	user := &models.User{
-		Username: req.Username,
-		Password: req.Password, // 密码会在 BeforeSave 钩子中哈希
+	resp, err := c.userService.CreateUser(&req)
+	if err != nil {
+		c.logger.Errorf("创建用户: 服务层调用失败: %v", err)
+		return controller.SendErrorResponse(ctx, controller.CodeInternalError, err.Error())
 	}

-	if err := c.userRepo.Create(user); err != nil {
-		c.logger.Errorf("创建用户: 创建用户失败: %v", err)
-
-		// 尝试查询用户，以判断是否是用户名重复导致的错误
-		_, findErr := c.userRepo.FindByUsername(req.Username)
-		if findErr == nil { // 如果能找到用户，说明是用户名重复
-			return controller.SendErrorResponse(ctx, controller.CodeConflict, "用户名已存在")
-		}
-
-		// 其他创建失败的情况
-		return controller.SendErrorResponse(ctx, controller.CodeInternalError, "创建用户失败")
-	}
-
-	return controller.SendResponse(ctx, controller.CodeCreated, "用户创建成功", dto.CreateUserResponse{
-		Username: user.Username,
-		ID:       user.ID,
-	})
+	return controller.SendResponse(ctx, controller.CodeCreated, "用户创建成功", resp)
 }

 // Login godoc
@@ -99,32 +70,13 @@ func (c *Controller) Login(ctx echo.Context) error {
 		return controller.SendErrorResponse(ctx, controller.CodeBadRequest, err.Error())
 	}

-	// 使用新的方法，通过唯一标识符（用户名、邮箱等）查找用户
-	user, err := c.userRepo.FindUserForLogin(req.Identifier)
+	resp, err := c.userService.Login(&req)
 	if err != nil {
-		if err == gorm.ErrRecordNotFound {
-			return controller.SendErrorResponse(ctx, controller.CodeUnauthorized, "登录凭证不正确")
-		}
-		c.logger.Errorf("登录: 查询用户失败: %v", err)
-		return controller.SendErrorResponse(ctx, controller.CodeInternalError, "登录失败")
+		c.logger.Errorf("登录: 服务层调用失败: %v", err)
+		return controller.SendErrorResponse(ctx, controller.CodeUnauthorized, err.Error())
 	}

-	if !user.CheckPassword(req.Password) {
-		return controller.SendErrorResponse(ctx, controller.CodeUnauthorized, "登录凭证不正确")
-	}
-
-	// 登录成功，生成 JWT token
-	tokenString, err := c.tokenService.GenerateToken(user.ID)
-	if err != nil {
-		c.logger.Errorf("登录: 生成令牌失败: %v", err)
-		return controller.SendErrorResponse(ctx, controller.CodeInternalError, "登录失败，无法生成认证信息")
-	}
-
-	return controller.SendResponse(ctx, controller.CodeSuccess, "登录成功", dto.LoginResponse{
-		Username: user.Username,
-		ID:       user.ID,
-		Token:    tokenString,
-	})
+	return controller.SendResponse(ctx, controller.CodeSuccess, "登录成功", resp)
 }

 // SendTestNotification godoc
@@ -155,8 +107,8 @@ func (c *Controller) SendTestNotification(ctx echo.Context) error {
 		return controller.SendErrorWithAudit(ctx, controller.CodeBadRequest, "请求体格式错误或缺少 'type' 字段: "+err.Error(), actionType, "请求体绑定失败", req)
 	}

-	// 3. 调用领域服务
-	err = c.notifyService.SendTestMessage(uint(userID), req.Type)
+	// 3. 调用服务层
+	err = c.userService.SendTestNotification(uint(userID), &req)
 	if err != nil {
 		c.logger.Errorf("%s: 服务层调用失败: %v", actionType, err)
 		return controller.SendErrorWithAudit(ctx, controller.CodeInternalError, "发送测试消息失败: "+err.Error(), actionType, "服务层调用失败", map[string]interface{}{"userID": userID, "type": req.Type})
--- a/internal/app/service/user_service.go
+++ b/internal/app/service/user_service.go
@@ -0,0 +1,110 @@
+package service
+
+import (
+	"errors"
+
+	"git.huangwc.com/pig/pig-farm-controller/internal/app/dto"
+	domain_notify "git.huangwc.com/pig/pig-farm-controller/internal/domain/notify"
+	"git.huangwc.com/pig/pig-farm-controller/internal/domain/token"
+	"git.huangwc.com/pig/pig-farm-controller/internal/infra/logs"
+	"git.huangwc.com/pig/pig-farm-controller/internal/infra/models"
+	"git.huangwc.com/pig/pig-farm-controller/internal/infra/repository"
+	"gorm.io/gorm"
+)
+
+// UserService 定义用户服务接口
+type UserService interface {
+	CreateUser(req *dto.CreateUserRequest) (*dto.CreateUserResponse, error)
+	Login(req *dto.LoginRequest) (*dto.LoginResponse, error)
+	SendTestNotification(userID uint, req *dto.SendTestNotificationRequest) error
+}
+
+// userService 实现了 UserService 接口
+type userService struct {
+	userRepo      repository.UserRepository
+	tokenService  token.Service
+	notifyService domain_notify.Service
+	logger        *logs.Logger
+}
+
+// NewUserService 创建并返回一个新的 UserService 实例
+func NewUserService(
+	userRepo repository.UserRepository,
+	tokenService token.Service,
+	notifyService domain_notify.Service,
+	logger *logs.Logger,
+) UserService {
+	return &userService{
+		userRepo:      userRepo,
+		tokenService:  tokenService,
+		notifyService: notifyService,
+		logger:        logger,
+	}
+}
+
+// CreateUser 创建新用户
+func (s *userService) CreateUser(req *dto.CreateUserRequest) (*dto.CreateUserResponse, error) {
+	user := &models.User{
+		Username: req.Username,
+		Password: req.Password, // 密码会在 BeforeSave 钩子中哈希
+	}
+
+	if err := s.userRepo.Create(user); err != nil {
+		s.logger.Errorf("创建用户: 创建用户失败: %v", err)
+
+		// 尝试查询用户，以判断是否是用户名重复导致的错误
+		_, findErr := s.userRepo.FindByUsername(req.Username)
+		if findErr == nil { // 如果能找到用户，说明是用户名重复
+			return nil, errors.New("用户名已存在")
+		}
+
+		// 其他创建失败的情况
+		return nil, errors.New("创建用户失败")
+	}
+
+	return &dto.CreateUserResponse{
+		Username: user.Username,
+		ID:       user.ID,
+	}, nil
+}
+
+// Login 用户登录
+func (s *userService) Login(req *dto.LoginRequest) (*dto.LoginResponse, error) {
+	// 使用新的方法，通过唯一标识符（用户名、邮箱等）查找用户
+	user, err := s.userRepo.FindUserForLogin(req.Identifier)
+	if err != nil {
+		if errors.Is(err, gorm.ErrRecordNotFound) {
+			return nil, errors.New("登录凭证不正确")
+		}
+		s.logger.Errorf("登录: 查询用户失败: %v", err)
+		return nil, errors.New("登录失败")
+	}
+
+	if !user.CheckPassword(req.Password) {
+		return nil, errors.New("登录凭证不正确")
+	}
+
+	// 登录成功，生成 JWT token
+	tokenString, err := s.tokenService.GenerateToken(user.ID)
+	if err != nil {
+		s.logger.Errorf("登录: 生成令牌失败: %v", err)
+		return nil, errors.New("登录失败，无法生成认证信息")
+	}
+
+	return &dto.LoginResponse{
+		Username: user.Username,
+		ID:       user.ID,
+		Token:    tokenString,
+	}, nil
+}
+
+// SendTestNotification 发送测试通知
+func (s *userService) SendTestNotification(userID uint, req *dto.SendTestNotificationRequest) error {
+	err := s.notifyService.SendTestMessage(userID, req.Type)
+	if err != nil {
+		s.logger.Errorf("发送测试通知: 服务层调用失败: %v", err)
+		return errors.New("发送测试消息失败: " + err.Error())
+	}
+	s.logger.Infof("发送测试通知: 成功为用户 %d 发送类型为 %s 的测试消息", userID, req.Type)
+	return nil
+}
--- a/internal/core/application.go
+++ b/internal/core/application.go
@@ -50,9 +50,9 @@ func NewApplication(configPath string) (*Application, error) {
 		appServices.MonitorService,
 		appServices.DeviceService,
 		appServices.PlanService,
+		appServices.UserService,
 		infra.TokenService,
 		appServices.AuditService,
-		infra.NotifyService,
 		infra.Lora.ListenHandler,
 	)

--- a/internal/core/component_initializers.go
+++ b/internal/core/component_initializers.go
@@ -186,8 +186,9 @@ type AppServices struct {
 	PigBatchService service.PigBatchService
 	MonitorService  service.MonitorService
 	DeviceService   service.DeviceService
-	AuditService    audit.Service
 	PlanService     service.PlanService
+	UserService     service.UserService
+	AuditService    audit.Service
 }

 // initAppServices 初始化所有的应用服务。
@@ -218,6 +219,7 @@ func initAppServices(infra *Infrastructure, domainServices *DomainServices, logg
 	)
 	auditService := audit.NewService(infra.Repos.UserActionLogRepo, logger)
 	planService := service.NewPlanService(logger, infra.Repos.PlanRepo, domainServices.AnalysisPlanTaskManager)
+	userService := service.NewUserService(infra.Repos.UserRepo, infra.TokenService, infra.NotifyService, logger)

 	return &AppServices{
 		PigFarmService:  pigFarmService,
@@ -226,6 +228,7 @@ func initAppServices(infra *Infrastructure, domainServices *DomainServices, logg
 		DeviceService:   deviceService,
 		AuditService:    auditService,
 		PlanService:     planService,
+		UserService:     userService,
 	}
 }